ref(processing): Add separate task and queue for transactions save_event #29480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beezz
force-pushed
the
ref/separate-save-event-transactions
branch
from
5b3dfbd to
ee3ba79
Compare
untitaker
approved these changes
Oct 21, 2021
beezz
force-pushed
the
ref/separate-save-event-transactions
branch
from
aaa62fc to
bd9c6ac
Compare
untitaker
approved these changes
Oct 22, 2021
tonyo
reviewed
Oct 24, 2021
Contributor
tonyo
left a comment
tonyo
left a comment
There was a problem hiding this comment.
- Would it be possible to add a (basic) test to make sure that the right task is called for transactions?
- I know it was briefly discussed, so just for completeness: rollout-wise, I'd recommend we either deploy the queue definition and task itself first (along with the separate workers), or do a rollout by increasing the sampling rate
beezz
force-pushed
the
ref/separate-save-event-transactions
branch
from
bd9c6ac to
66ffc76
Compare
untitaker
approved these changes
Oct 27, 2021
beezz
force-pushed
the
ref/separate-save-event-transactions
branch
from
8618092 to
e379fc4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using separate queue and workers for
save_eventof transaction events should result in slower backlog buildup in cases like contention on project counter.