fix: Always allow deletion of custom symbol sources [NATIVE-270] #29482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Oct 21, 2021
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Could we add a unittest to tests/sentry/api/endpoints/test_project_details.py ProjectUpdateTest that checks this?
flub
reviewed
Oct 27, 2021
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
LGMT but... github won't let me hit approve
Swatinem
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
validate_symbolSourcesso that theorganizations:custom-symbol-sourcesflag is only checked if the user is trying to add new sources. Deletion is always allowed.