fix(dashboards): Fix inconsistent widget query legends #29510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems because of the async nature of the promises being resolved for widget queries, simply concating raw results doesn't work because the order isn't ensured. Instead, we want to use the index as a key here so that we can always ensure the raw results are in the same order as the widgetQueries.
shruthilayaj
changed the title
wmak
approved these changes
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems because of the async nature of
the promises being resolved for widget
queries, simply concating raw results
doesn't work because the order isn't
ensured. Instead, we want to use the index
as a key here so that we can always
ensure the raw results are in the same
order as the widgetQueries.
Example of weird labels (Note how Releases and the NEW series have switched):
