Skip to content

ref(ui): Rename and type componentDidUpdate arguments #29533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejminar merged 4 commits into from
Oct 25, 2021
Merged

ref(ui): Rename and type componentDidUpdate arguments #29533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e12655b
ref(ui): Rename and type componentDidUpdate arguments
matejminar Oct 25, 2021
3db6f0f
Update static/app/views/settings/projectPlugins/details.tsx
matejminar Oct 25, 2021
c890102
ref(crashContent): Move crash content related files to folder (#29509)
priscilawebdev Oct 25, 2021
1b742dd
Merge branch 'master' into ref/rename-prevContext
matejminar Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/views/releases/detail/commitsAndFiles/commits.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ class Commits extends AsyncView<Props, State> {
};
}

componentDidUpdate(prevProps: Props, prevContext: Record<string, any>) {
componentDidUpdate(prevProps: Props, prevState: State) {
if (prevProps.activeReleaseRepo?.name !== this.props.activeReleaseRepo?.name) {
this.remountComponent();
return;
}
super.componentDidUpdate(prevProps, prevContext);
super.componentDidUpdate(prevProps, prevState);
}

getEndpoints(): ReturnType<AsyncView['getEndpoints']> {
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/releases/detail/commitsAndFiles/filesChanged.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ class FilesChanged extends AsyncView<Props, State> {
};
}

componentDidUpdate(prevProps: Props, prevContext: Record<string, any>) {
componentDidUpdate(prevProps: Props, prevState: State) {
if (prevProps.activeReleaseRepo?.name !== this.props.activeReleaseRepo?.name) {
this.remountComponent();
return;
}
super.componentDidUpdate(prevProps, prevContext);
super.componentDidUpdate(prevProps, prevState);
}

getEndpoints(): ReturnType<AsyncView['getEndpoints']> {
Expand Down
19 changes: 13 additions & 6 deletions static/app/views/releases/detail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class ReleasesDetail extends AsyncView<Props, State> {
};
}

componentDidUpdate(prevProps, prevContext: Record<string, any>) {
componentDidUpdate(prevProps: Props, prevState: State) {
const {organization, params, location} = this.props;

if (
Expand All @@ -103,7 +103,7 @@ class ReleasesDetail extends AsyncView<Props, State> {
this.pickLocationQuery(location)
)
) {
super.componentDidUpdate(prevProps, prevContext);
super.componentDidUpdate(prevProps, prevState);
}
}

Expand Down Expand Up @@ -227,9 +227,13 @@ class ReleasesDetail extends AsyncView<Props, State> {
}
}

type ReleasesDetailContainerProps = Omit<Props, 'releaseMeta'>;
type ReleasesDetailContainerState = {
releaseMeta: ReleaseMeta | null;
} & AsyncComponent['state'];
class ReleasesDetailContainer extends AsyncComponent<
Omit<Props, 'releaseMeta'>,
{releaseMeta: ReleaseMeta | null} & AsyncComponent['state']
ReleasesDetailContainerProps,
ReleasesDetailContainerState
> {
shouldReload = true;

Expand All @@ -250,15 +254,18 @@ class ReleasesDetailContainer extends AsyncComponent<
this.removeGlobalDateTimeFromUrl();
}

componentDidUpdate(prevProps, prevContext: Record<string, any>) {
componentDidUpdate(
prevProps: ReleasesDetailContainerProps,
prevState: ReleasesDetailContainerState
) {
const {organization, params} = this.props;

this.removeGlobalDateTimeFromUrl();
if (
prevProps.params.release !== params.release ||
prevProps.organization.slug !== organization.slug
) {
super.componentDidUpdate(prevProps, prevContext);
super.componentDidUpdate(prevProps, prevState);
}
}

Expand Down
4 changes: 2 additions & 2 deletions static/app/views/settings/projectPlugins/details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ type State = {
* PluginsStore
*/
class ProjectPluginDetails extends AsyncView<Props, State> {
componentDidUpdate(prevProps: Props, prevContext: any) {
super.componentDidUpdate(prevProps, prevContext);
componentDidUpdate(prevProps: Props, prevState: State) {
super.componentDidUpdate(prevProps, prevState);
if (prevProps.params.pluginId !== this.props.params.pluginId) {
this.recordDetailsViewed();
}
Expand Down