feat(perf): Fill out frontend-other tab #29545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fills out the frontend-other tab as well as fixing a couple issues with local storage between tabs (using a provider to add additional context about the current view to the key, the name isn't great though).
k-fish
commented
Oct 25, 2021
| name: 'CurrentPerformanceViewContext', | ||
| }); | ||
|
|
||
| export {CurrentPerformanceViewProvider}; |
Member
Author
There was a problem hiding this comment.
The current performance view context is a bit of a weird name, suggestions welcome.
Member
There was a problem hiding this comment.
How about just PerformanceDisplayProvider?
Contributor
size-limit report
|
Zylphrex
approved these changes
Oct 25, 2021
| name: 'CurrentPerformanceViewContext', | ||
| }); | ||
|
|
||
| export {CurrentPerformanceViewProvider}; |
Member
There was a problem hiding this comment.
How about just PerformanceDisplayProvider?
Comment on lines
51
to
55
| const key = getContainerKey(index, performanceType, height); | ||
| const localObject = JSON.parse( | ||
| localStorage.getItem(getContainerLocalStorageObjectKey) || '{}' | ||
| ); | ||
| const value = localObject?.[key]; |
Member
There was a problem hiding this comment.
Should this be refactored into some utility function to handle the parsing instead of directly using the localStorage API now that you're storing an object?
…dd-frontend-other
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fills out the frontend-other tab as well as fixing a couple issues with local storage between tabs (using a provider to add additional context about the current view to the key).