feat(suspect-spans): Add endpoint for listing span ops #29559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the array join clause in clickhouse through SnQL. The array join clause is like a database join but instead of joining two tables, the join is performed on the table with the array.
This introduces a new endpoint for getting a list of span ops. Support for searching for an op does not exist yet.
wmak
approved these changes
Oct 26, 2021
Member
wmak
left a comment
wmak
left a comment
There was a problem hiding this comment.
LGTM, but a bit confused by the title of this PR clashing with the description. I assume the title is outdated?
|
|
||
| return self.store_event(data, project_id=self.project.id) | ||
|
|
||
| @pytest.mark.skip("setting snuba config is too slow") |
Member
There was a problem hiding this comment.
Could we mock snuba for these endpoint tests, since the snuba functionality is "tested" elsewhere?
Member
Author
There was a problem hiding this comment.
I'll do that in a follow-up PR 👍
Base automatically changed from
feat/support-for-array-join-clause-in-snql
to
master
October 27, 2021 14:02
Zylphrex
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new endpoint for getting a list of span ops. Support for
searching for an op does not exist yet.