Skip to content

fix(appstore-connect): Detect and use new iTunes credentials when updating ASC creds [NATIVE-292] #29561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
relaxolotl merged 3 commits into from
Oct 27, 2021
Merged

fix(appstore-connect): Detect and use new iTunes credentials when updating ASC creds [NATIVE-292] #29561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e52a01
fix(appstore-connect): Detect and use new credentials if they are pro…
relaxolotl Oct 25, 2021
98f6122
show a better error message when bad iTunes credentials are provided
relaxolotl Oct 25, 2021
e6204cd
minor rename
relaxolotl Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/sentry/api/endpoints/project_app_store_connect_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,16 +563,19 @@ def post(self, request: Request, project: Project) -> Response:
password = serializer.validated_data.get("itunesPassword")
credentials_id = serializer.validated_data.get("id")

if credentials_id is not None:
no_new_password = not password or password == {"hidden-secret": True}
source_credentials_from_project = not user_name or no_new_password

if credentials_id is not None and source_credentials_from_project:
try:
symbol_source_config = appconnect.AppStoreConnectConfig.from_project_config(
project, credentials_id
)
except KeyError:
return Response("No credentials found.", status=400)

user_name = symbol_source_config.itunesUser
password = symbol_source_config.itunesPassword
user_name = symbol_source_config.itunesUser if not user_name else user_name
password = symbol_source_config.itunesPassword if no_new_password else password

if user_name is None:
return Response("No user name provided.", status=400)
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/utils/appleconnect/itunes_connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def start_login_sequence(self, username: str, password: str) -> None:
self._session_id = start_login.headers["x-apple-id-session-id"]
self._scnt = start_login.headers["scnt"]
self.state = ClientState.AUTH_REQUESTED
elif start_login.status_code == http.HTTPStatus.UNAUTHORIZED:
elif start_login.status_code in [http.HTTPStatus.UNAUTHORIZED, http.HTTPStatus.FORBIDDEN]:
raise InvalidUsernamePasswordError
else:
raise ITunesError(f"Unexpected status code form sign in: {start_login.status_code}")
Expand Down