feat(discover): Allow sorting on events-geo endpoint #29572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
approved these changes
Oct 26, 2021
| limit=limit, | ||
| referrer=referrer, | ||
| use_aggregate_conditions=True, | ||
| orderby=self.get_orderby(request), |
Member
There was a problem hiding this comment.
Could we default an orderby here if the user doesn't supply one?
Contributor
Author
|
We are favouring World Map previews over Bar Chart so there is no longer a use case for this, closing this pr for now. @wmak |
Contributor
Author
|
Discussed with team, this is still useful since we want results to be ordered anyways 😃 reopening |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to sort when calling the
events-geoendpoint. Will be using this to sort world map queries by value for rendering their previews in sorted bar chart form.