fix(appconnect): Fix permissions of validate endpoint [ISSUE-1329] #29599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all users which end up hitting this endpoint are admins and they don't need to, there is no sensitive info here. Allowing this makes the page work much better as things will actually load.
Contributor
|
really minor nitpicky comment: could i bug you to update the documentation on the endpoint both at the top of the file and in its docstring to say that it's a |
Swatinem
approved these changes
Oct 27, 2021
relaxolotl
approved these changes
Oct 27, 2021
Contributor
relaxolotl
left a comment
relaxolotl
left a comment
There was a problem hiding this comment.
tested this with my regular member user and it looks good 👍 thanks for fixing this!
priscilawebdev
approved these changes
Oct 28, 2021
Member
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
thanks for doing this 🙇♀️
flub
changed the title
| :class:`AppStoreConnectUpdateCredentialsEndpoint`. | ||
| 7. ``POST projects/{org_slug}/{proj_slug}/appstoreconnect/validate/{id}/`` | ||
| 7. ``GET projects/{org_slug}/{proj_slug}/appstoreconnect/validate/{id}/`` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all users which end up hitting this endpoint are admins and they
don't need to, there is no sensitive info here. Allowing this makes
the page work much better as things will actually load.