fix(owners): Fix bug in path matching for project owners
#29629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we match on path we currently try to access `filename` from the frame, and if not present we use `abs_path`. This means that for any frames that have both `filename` and `abs_path` it's not possible to match on a segment of the path. This pr changes the behaviour of `path` to check both `filename` and `abs_path`. If we want to be more conservative with this matching change we could add a new `abs_path` matching option, but I feel like that would be adding more bloat to understanding this feature.
Member
Author
|
@untitaker I pinged you here since you edited this recently, but not sure if you have any opinions on whether this makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we match on path we currently try to access
filenamefrom the frame, and if not present weuse
abs_path. This means that for any frames that have bothfilenameandabs_pathit's notpossible to match on a segment of the path.
This pr changes the behaviour of
pathto check bothfilenameandabs_path. If we want to bemore conservative with this matching change we could add a new
abs_pathmatching option, but Ifeel like that would be adding more bloat to understanding this feature.