fix(codeowners): Handle IndexError when generating regex #29642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sentry/ownership/grammar.py
Outdated
| trailing_slash_star = pattern[-1] == "*" and len(pattern) > 1 and pattern[-2] == "/" | ||
| try: | ||
| trailing_slash_star = pattern[-1] == "*" and len(pattern) > 1 and pattern[-2] == "/" | ||
| except IndexError: |
Contributor
There was a problem hiding this comment.
Could we just check for a pattern length of 1 and return False for that?
Contributor
Author
There was a problem hiding this comment.
@AniketDas-Tekky this is searching for the /* case. It needs to look for both characters.
Contributor
There was a problem hiding this comment.
So if the pattern length is 1, then it can never be /*
Contributor
There was a problem hiding this comment.
I just think we should prevent the exception from happening in the first place instead of doing a try/catch
Contributor
Author
There was a problem hiding this comment.
@AniketDas-Tekky ahh that's what you meant! makes sense!
Contributor
Author
There was a problem hiding this comment.
@AniketDas-Tekky hmm we already do a check for that in that expression
AniketDas-Tekky
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-S38