ref(str): Use f-strings #29680
Merged
ref(str): Use f-strings #29680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceorourke
reviewed
Oct 29, 2021
| exact_query = ('name="%s"' % (query)).encode("utf-8") | ||
| fuzzy_query = ('name~"%s"' % (query)).encode("utf-8") | ||
| exact_query = f'name="{query}"'.encode() | ||
| fuzzy_query = f'name~"{query}"'.encode() |
Member
There was a problem hiding this comment.
Do you not need to specify utf-8?
Member
There was a problem hiding this comment.
I guess the default w/ no parameters is utf-8
Contributor
Author
There was a problem hiding this comment.
Oh I didn't even notice this. One of the commit hooks removed the parameter.
ceorourke
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
%string interpolation with f-strings.