fix(discover): Set field to prev value if required but empty (#269) #29686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't pass required as a prop to the input element, an empty string was considered valid for required fields and incorrectly set.
shruthilayaj
reviewed
Nov 1, 2021
Member
shruthilayaj
left a comment
shruthilayaj
left a comment
There was a problem hiding this comment.
Looks good! Can we just write a quick test in tests/js/spec/views/eventsV2/table/columnEditModal.spec.js for this?
narsaynorath
force-pushed
the
fix/clearing-parameter-in-column-editor-modal
branch
from
5d082cd to
ccf06e0
Compare
shruthilayaj
reviewed
Nov 1, 2021
narsaynorath
force-pushed
the
fix/clearing-parameter-in-column-editor-modal
branch
from
ccf06e0 to
0ec318c
Compare
narsaynorath
force-pushed
the
fix/clearing-parameter-in-column-editor-modal
branch
from
0ec318c to
fc91532
Compare
narsaynorath
deleted the
fix/clearing-parameter-in-column-editor-modal
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't pass required as a prop to the input element*, an empty
string was considered valid for required fields and incorrectly set.
*See:
in
app/views/settings/components/forms/controls/input.tsx