feat(discover): Render saved Query error messages to MiniGraph #29700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a render prop to EventsRequest component for passing along the error message and rendering in MiniGraph
narsaynorath
commented
Nov 1, 2021
Contributor
size-limit report
|
narsaynorath
changed the title
edwardgou-sentry
approved these changes
Nov 2, 2021
Contributor
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
There was a problem hiding this comment.
Changes look solid to me, nice!
shruthilayaj
approved these changes
Nov 2, 2021
Member
shruthilayaj
left a comment
shruthilayaj
left a comment
There was a problem hiding this comment.
Just a small suggestion, otherwise LGTM
edwardgou-sentry
approved these changes
Nov 2, 2021
narsaynorath
deleted the
feat/move-query-errors-directly-to-saved-query
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a render prop to EventsRequest component for passing along the
error message and rendering in MiniGraph