fix(idp-migration): added 2fa to idp migration flow #29701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leedongwei
reviewed
Nov 2, 2021
| self._login(acting_user) | ||
| except self._NotCompletedSecurityChecks: | ||
| if acting_user.has_usable_password(): | ||
| if acting_user.has_usable_password() or is_account_verified: |
Member
There was a problem hiding this comment.
Can you write a comment + add a test for this?
This is one of those subtle edge-cases and I'd prefer if it's behaviour is documented.
leedongwei
approved these changes
Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: During the idp migration flow, the user won't be be linked to their SSO provider if they had 2fa enabled. This was due to the user not completing the security checks during after their redis has been verified.
Now if their account has been verified and they dont pass security checks, we redirect them to the 2fa flow so they could be linked with their SSO provider
https://getsentry.atlassian.net/browse/ER-856