feat(notifications): slack request notifications read settings #29718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 2, 2021 10:51
ceorourke
reviewed
Nov 2, 2021
| @@ -0,0 +1,58 @@ | |||
| from sentry.models import NotificationSetting, OrganizationMember | |||
Member
There was a problem hiding this comment.
Why put this in a new directory instead of with the other slack notif tests?
Contributor
Author
There was a problem hiding this comment.
@ceorourke My understanding is that the location of tests should match the file of the main entity being tested
Contributor
Author
There was a problem hiding this comment.
On wait, this is not supposed to be in the slack directory...good catch!
ceorourke
approved these changes
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to check notification settings for the new
OrganizationRequestNotificationclass which uses theAPPROVALtype settings. Note, because these notifications are relatively infrequent, we are going to default to allowing Slack notifications instead of forcing the user to opt into them.