Skip to content

fix(perf): Landing v3 add min filter for fields #29740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-fish merged 1 commit into from
Nov 3, 2021
Merged

fix(perf): Landing v3 add min filter for fields #29740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 23 additions & 29 deletions static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ type DataType = {
list: WidgetDataResult & ReturnType<typeof transformDiscoverToList>;
};

const slowList = [
PerformanceWidgetSetting.SLOW_HTTP_OPS,
PerformanceWidgetSetting.SLOW_DB_OPS,
PerformanceWidgetSetting.SLOW_BROWSER_OPS,
PerformanceWidgetSetting.SLOW_RESOURCE_OPS,
PerformanceWidgetSetting.MOST_SLOW_FRAMES,
PerformanceWidgetSetting.MOST_FROZEN_FRAMES,
];

export function LineChartListWidget(props: Props) {
const [selectedListIndex, setSelectListIndex] = useState<number>(0);
const {ContainerActions} = props;
Expand All @@ -57,31 +66,24 @@ export function LineChartListWidget(props: Props) {
`Line chart list widget can only accept a single field (${props.fields})`
);
}
const field = props.fields[0];

const slowList = [
PerformanceWidgetSetting.SLOW_HTTP_OPS,
PerformanceWidgetSetting.SLOW_DB_OPS,
PerformanceWidgetSetting.SLOW_BROWSER_OPS,
PerformanceWidgetSetting.SLOW_RESOURCE_OPS,
PerformanceWidgetSetting.MOST_SLOW_FRAMES,
PerformanceWidgetSetting.MOST_FROZEN_FRAMES,
];
const isSlowestType = slowList.includes(props.chartSetting);

const eventView = props.eventView.clone();

const listQuery = useMemo<QueryDefinition<DataType, WidgetDataResult>>(
() => ({
fields: props.fields[0],
fields: field,
component: provided => {
eventView.sorts = [{kind: 'desc', field: props.fields[0]}];
eventView.sorts = [{kind: 'desc', field}];
if (props.chartSetting === PerformanceWidgetSetting.MOST_RELATED_ISSUES) {
eventView.fields = [
{field: 'issue'},
{field: 'transaction'},
{field: 'title'},
{field: 'project.id'},
{field: props.fields[0]},
{field},
];
eventView.additionalConditions.setFilterValues('event.type', ['error']);
eventView.additionalConditions.setFilterValues('!tags[transaction]', ['']);
Expand All @@ -90,19 +92,16 @@ export function LineChartListWidget(props: Props) {
eventView.query = mutableSearch.formatString();
} else if (isSlowestType) {
eventView.additionalConditions.setFilterValues('epm()', ['>0.01']);
eventView.additionalConditions.setFilterValues(field, ['>0']);
eventView.fields = [
{field: 'transaction'},
{field: 'project.id'},
{field: 'epm()'},
{field: props.fields[0]},
{field},
];
} else {
// Most related errors
eventView.fields = [
{field: 'transaction'},
{field: 'project.id'},
{field: props.fields[0]},
];
eventView.fields = [{field: 'transaction'}, {field: 'project.id'}, {field}];
}
return (
<DiscoverQuery
Expand All @@ -115,15 +114,15 @@ export function LineChartListWidget(props: Props) {
},
transform: transformDiscoverToList,
}),
[props.eventView.query, props.fields[0], props.organization.slug]
[props.eventView.query, field, props.organization.slug]
);

const chartQuery = useMemo<QueryDefinition<DataType, WidgetDataResult>>(() => {
return {
enabled: widgetData => {
return !!widgetData?.list?.data?.length;
},
fields: props.fields[0],
fields: field,
component: provided => {
eventView.additionalConditions.setFilterValues('transaction', [
provided.widgetData.list.data[selectedListIndex].transaction as string,
Expand All @@ -133,7 +132,7 @@ export function LineChartListWidget(props: Props) {
{field: 'issue'},
{field: 'issue.id'},
{field: 'transaction'},
{field: props.fields[0]},
{field},
];
eventView.additionalConditions.setFilterValues('issue', [
provided.widgetData.list.data[selectedListIndex].issue as string,
Expand All @@ -144,7 +143,7 @@ export function LineChartListWidget(props: Props) {
mutableSearch.removeFilter('transaction.duration');
eventView.query = mutableSearch.formatString();
} else {
eventView.fields = [{field: 'transaction'}, {field: props.fields[0]}];
eventView.fields = [{field: 'transaction'}, {field}];
}
return (
<EventsRequest
Expand All @@ -153,7 +152,7 @@ export function LineChartListWidget(props: Props) {
includePrevious
includeTransformedData
partial
currentSeriesNames={[props.fields[0]]}
currentSeriesNames={[field]}
query={eventView.getQueryWithAdditionalConditions()}
interval={getInterval(
{
Expand All @@ -168,12 +167,7 @@ export function LineChartListWidget(props: Props) {
},
transform: transformEventsRequestToArea,
};
}, [
props.eventView.query,
props.fields[0],
props.organization.slug,
selectedListIndex,
]);
}, [props.eventView.query, field, props.organization.slug, selectedListIndex]);

const Queries = {
list: listQuery,
Expand Down Expand Up @@ -238,7 +232,7 @@ export function LineChartListWidget(props: Props) {
additionalQuery,
});

const fieldString = getAggregateAlias(props.fields[0]);
const fieldString = getAggregateAlias(field);

const valueMap = {
[PerformanceWidgetSetting.MOST_RELATED_ERRORS]: listItem.failure_count,
Expand Down