Skip to content

fix(discover): disable bar chart animation on discover #29783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardgou-sentry merged 2 commits into from
Nov 8, 2021
Merged

fix(discover): disable bar chart animation on discover #29783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3134426
disabled bar chart animation
edwardgou-sentry Nov 4, 2021
d3ed6d9
update to just affect discover
edwardgou-sentry Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion static/app/components/charts/barChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@ export type BarChartSeries = Series & Omit<EChartOption.SeriesBar, 'data' | 'nam
type Props = Omit<ChartProps, 'series'> & {
series: BarChartSeries[];
stacked?: boolean;
animation?: boolean;
};

class BarChart extends React.Component<Props> {
render() {
const {series, stacked, xAxis, ...props} = this.props;
const {series, stacked, xAxis, animation, ...props} = this.props;

return (
<BaseChart
Expand All @@ -33,6 +34,7 @@ class BarChart extends React.Component<Props> {
}
return {value: [name, value], itemStyle};
}),
animation,
...options,
})
)}
Expand Down
1 change: 1 addition & 0 deletions static/app/components/charts/eventsChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ class Chart extends React.Component<ChartProps, State> {
},
},
...(chartOptionsProp ?? {}),
animation: typeof Component === typeof BarChart ? false : undefined,
};

return (
Expand Down