Skip to content

fix(appstore-connect): Return more detailed errors when API credentials are unusable during setup #29808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
relaxolotl merged 2 commits into from
Nov 9, 2021
Merged

fix(appstore-connect): Return more detailed errors when API credentials are unusable during setup #29808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1e82d
fix(appstore-connect): Return more detailed errors when API credentia…
relaxolotl Nov 4, 2021
e2a683a
remove no-op instantiation
relaxolotl Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/sentry/api/endpoints/project_app_store_connect_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,15 @@ def post(self, request: Request, project: Project) -> Response:
)
session = requests.Session()

apps = appstore_connect.get_apps(session, credentials)
try:
apps = appstore_connect.get_apps(session, credentials)
except appstore_connect.UnauthorizedError:
raise AppConnectAuthenticationError
except appstore_connect.ForbiddenError:
raise AppConnectForbiddenError

if apps is None:
raise AppConnectAuthenticationError()
raise AppConnectAuthenticationError

all_apps = [
{"name": app.name, "bundleId": app.bundle_id, "appId": app.app_id} for app in apps
Expand Down