fix(appstore-connect): Fix empty dSYMUrl detection #29830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relaxolotl
force-pushed
the
appconnect/fix-appclip-dsyms
branch
from
a6eedd8 to
89c4125
Compare
flub
reviewed
Nov 8, 2021
relaxolotl
force-pushed
the
appconnect/fix-appclip-dsyms
branch
from
ebc4a54 to
1543574
Compare
flub
approved these changes
Nov 8, 2021
loewenheim
approved these changes
Nov 8, 2021
relaxolotl
force-pushed
the
appconnect/fix-appclip-dsyms
branch
from
e7c77ed to
4131849
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29704 check for the presence of dSYMS was slightly off, see SENTRY-SN6. The code uses an enum to represent cases where there is no dSYM present, so the truthy check for a url would always pass, causing app clip dsyms to always be reported.
This adds tests to verify the logic as well.