ref(profiling): Group related hooks in flamegraph zoom view #31639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd trim text more accurately
Contributor
size-limit report
|
Previously, much of the functionalities of the flamegraph zoom view was grouped into a large `useEffect`. This refactor breaks it up into smaller pieces. To summarize - Renderers have been lifted to the top using `useMemo`. - All draw calls to the renderers are grouped in a single `useEffect`. - All event listeners on the scheduler are gropued in a single `useEffect`.
Zylphrex
force-pushed
the
txiao/ref/flamegraph-view
branch
from
3705bdb to
a8e272f
Compare
Base automatically changed from
jb/profiling/flamegraph-view
to
jb/profiling/flamegraph-renderer
February 9, 2022 07:18
JonasBa
force-pushed
the
jb/profiling/flamegraph-renderer
branch
from
ddde2ca to
0dff416
Compare
Member
Author
|
Gonna close this for now, too many merge conflicts to deal with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, much of the functionalities of the flamegraph zoom view was grouped
into a large
useEffect. This refactor breaks it up into smaller pieces. Tosummarize
useMemo.useEffect.useEffect.