Strip ports from IPv4-only IPs. #3421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sentry/middleware/proxy.py
Outdated
| # Take just the first one. | ||
| real_ip = real_ip.split(",")[0] | ||
| if ':' in real_ip: | ||
| if '.' in real_ip and ':' in real_ip: |
Contributor
There was a problem hiding this comment.
Can we switch these around?
To if ':' in real_ip and '.' in real_ip: since it'll be a tad faster for the common case where : doesn't exist.
Contributor
|
🍪 |
mattrobenolt
pushed a commit
that referenced
this pull request
Jun 6, 2016
* Add a period to the IP checker to ensure it only finds IPv4. * Add a test case for both IP versions. * IPv4 is still the most popular but it's 2016. :sadface:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3416.
cc @rdoursenaud / @getsentry/infrastructure