Don't fire off a stampeded of Team/Project deletion tasks #4006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that within each iteration, delete_* didn't actually delete the object, so every time it loops back on itself, it keeps firing off additional tasks to delete the same object over and over again until it's actually gone.
Contributor
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
mattrobenolt
added a commit
that referenced
this pull request
Sep 2, 2016
mattrobenolt
added a commit
that referenced
this pull request
Sep 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that within each iteration, delete_* didn't actually
delete the object, so every time it loops back on itself, it keeps
firing off additional tasks to delete the same object over and over
again until it's actually gone.
@getsentry/infrastructure
This change is