Skip to content

enable TLS verification of source map requests if there is a secure token #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

enable TLS verification of source map requests if there is a secure token #4016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sentry/lang/javascript/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,13 @@ def fetch_file(url, project=None, release=None, allow_scraping=True):
domain_result['url'] = url
raise CannotFetchSource(domain_result)

verify_tls = False

headers = {}
if project and is_valid_origin(url, project=project):
token = project.get_option('sentry:token')
if token:
verify_tls = True
headers['X-Sentry-Token'] = token

logger.debug('Fetching %r from the internet', url)
Expand All @@ -340,7 +343,7 @@ def fetch_file(url, project=None, release=None, allow_scraping=True):
response = http_session.get(
url,
allow_redirects=True,
verify=False,
verify=verify_tls,
headers=headers,
timeout=settings.SENTRY_SOURCE_FETCH_TIMEOUT,
)
Expand Down