Skip to content

Conversation

@mattrobenolt
Copy link
Contributor

@mattrobenolt mattrobenolt commented Sep 2, 2016

Fixes SENTRY-1X6

@getsentry/infrastructure


This change is Reviewable

@mattrobenolt
Copy link
Contributor Author

@tkaemming
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/sentry/models/grouprelease.py, line 35 [r1] (raw file):

        return 'grouprelease:1:{}:{}'.format(
            group_id,
            md5_text(u'{}:{}'.format(release_id, environment)).hexdigest(),

Wonder how hard it'd be to write a linter to warn if calling .format on a string literal…


Comments from Reviewable

@mattrobenolt mattrobenolt merged commit c3baa7d into master Sep 2, 2016
@mattrobenolt mattrobenolt deleted the unicodddeeeeee branch September 2, 2016 23:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants