Skip to content

Minor mobile display improvements for weekly report emails. #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkaemming merged 4 commits into from
Nov 1, 2016
Merged

Minor mobile display improvements for weekly report emails. #4464

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0432522
Decrease width of spectrum items.
tkaemming Nov 1, 2016
8fb9eb8
Remove line height from stacked bars.
tkaemming Nov 1, 2016
f943c78
Improve project breakdown label rendering.
tkaemming Nov 1, 2016
41eb207
Tweak 3 month history header.
tkaemming Nov 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions src/sentry/templates/sentry/emails/reports/body.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@
color: #fff;
}

.graph .bar {
margin-bottom: 0;
}

.graph .bar td,
.graph .bar th {
line-height: 0;
}

.issue-graph {
table-layout: fixed;
}
Expand All @@ -54,13 +63,13 @@
color: #848296;
}

.legend .all,
.issue-graph-bar .all {
#events-seen .legend .all,
#events-seen .bar .all {
background-color: #ebe9f7;
}

.legend .resolved,
.issue-graph-bar .resolved {
#events-seen .legend .resolved,
#events-seen .bar .resolved {
background-color: #6C5FC7;
}

Expand Down Expand Up @@ -93,20 +102,19 @@
vertical-align: middle;
}

.issue-graph, .issue-graph-bar {
.issue-graph, .issue-graph .bar {
margin-bottom: 0;
}

.issue-graph-bar td {
.issue-graph .bar td {
font-size: 0;
}

.project-breakdown {
margin-bottom: 40px;
margin-bottom: 20px;
}

.project-breakdown .graph {
margin-bottom: 10px;
table-layout: fixed;
}

Expand Down Expand Up @@ -228,6 +236,10 @@
padding-right: 20px;
}

#history-calendars h4 {
margin-bottom: 0px;
}

</style>

<style type="text/css" inline="false">
Expand All @@ -253,7 +265,7 @@
text-align: center !important;
}

.issue-graph-bar .all {
#events-seen .bar .all {
background-color: #6C5FC7 !important;
}

Expand Down Expand Up @@ -302,19 +314,11 @@
height: 8px !important;
}

#history-calendars h4 {
margin-bottom: 0px !important;
}

.spectrum {
margin: 20px 0 0 !important;
text-align: center !important;
}

.spectrum .range span {
width: 10px !important;
}

}

</style>
Expand Down Expand Up @@ -363,7 +367,7 @@ <h4>Events Seen {{ duration.noun|title }}</h4>
{% with report.series.maximum as max %}
{% for timestamp, metrics in report.series.points %}
<td valign="bottom" style="width: {% widthratio 1 report.series.points|length 100 %}%">
<table class="issue-graph-bar">
<table class="bar">
{% if metrics.resolved or metrics.unresolved %}
<tr>
<td class="all" height="{% widthratio metrics.unresolved max 52 %}px" title="{{ metrics.unresolved }}">&nbsp;</td>
Expand Down Expand Up @@ -459,25 +463,27 @@ <h4>Events by Project</h4>
<tr>
{% for timestamp, values in series.points %}
<td valign="bottom" class="bar" style="height: {{ height }}px; width: {% widthratio 1 series.points|length 100 %}%">
<table>
<table class="bar">
{% for key, count in values %}
<tr>
<td height="{% widthratio count series.maximum height %}" style="background-color: {{ key.color }};">&nbsp;</td>
</tr>
{% empty %}
<tr>
<td height="1" style="background-color: #ebe9f7;"></td>
</td>
{% endfor %}
<tr>
<td class="label">
{{ timestamp|date:duration.date_format }}
</tr>
</td>
{% endfor %}
</table>
</td>
{% endfor %}
</tr>
<tr>
{% for timestamp, values in series.points %}
<td class="label" style="width: {% widthratio 1 series.points|length 100 %}%">
{{ timestamp|date:duration.date_format }}
</td>
{% endfor %}
</tr>
</table>

<table class="summary">
Expand Down Expand Up @@ -519,7 +525,7 @@ <h4>Events by Project</h4>
<th style="width: 300px;">
<h4>3 Month History</h4>
</th>
<td class="spectrum">
<td class="spectrum" style="vertical-align: bottom;">
Less Events
<div class="range">{% for color in report.calendar.legend %}<span style="background-color: {{ color }}">&nbsp;</span>{% endfor %}</div>
More Events
Expand Down