ui: various improvements to forms #5660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch ApiCreateToken to ApiForm - switch AdminSettings to ApiForm - fix issue with PasswordField and FormState - add requireChanges (defaults to false) to Form - add optional onCancel (and a Cancel action) to Form
dcramer
force-pushed
the
ui/more-form-improvements
branch
from
d13e5ad to
846fecc
Compare
Member
Author
|
note: the AdminSettings snapshot test is useless, and im not sure the best path forward for it |
dcramer
force-pushed
the
ui/more-form-improvements
branch
from
8ec7093 to
4926761
Compare
dcramer
force-pushed
the
ui/more-form-improvements
branch
from
4926761 to
db08157
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#nochanges