Skip to content

add empty migration to fix state from conflicting migrations #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macqueen merged 1 commit into from
Jun 30, 2017
Merged

add empty migration to fix state from conflicting migrations #5667

macqueen merged 1 commit into from
Jun 30, 2017

Conversation

@macqueen
Copy link
Contributor

@macqueen macqueen commented Jun 30, 2017 •
edited
Loading

#nochanges

cc @ehfeng

@macqueen macqueen requested a review from mattrobenolt June 30, 2017 18:41
@ghost
Copy link

ghost commented Jun 30, 2017 •
edited by ghost
Loading

1 Warning
⚠️ PR includes migrations

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

@macqueen macqueen merged commit 9e88320 into master Jun 30, 2017
@macqueen macqueen deleted the fix-migrations branch June 30, 2017 19:42
@ehfeng
Copy link
Contributor

ehfeng commented Jun 30, 2017

Oh, I forgot to do one last migration check before I merged scheduled jobs yesterday and the Dangerbot was acting up. Sorry about that :(

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mattrobenolt mattrobenolt mattrobenolt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macqueen @ehfeng @mattrobenolt