Remove unique tag counts display. #5669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This one looks kind of bad, but I'm not sure how many people view this page to begin with:
|
dcramer
approved these changes
Jun 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently has a few issues:
1.) This value is the number of tags that have been seen across the entire project -- not just the number of tags that have been seen for this issue -- so it's super confusing on the group tag page when all of the other values are scoped to values seen within the group. This reference was removed for the
GroupTagValuesReact view with GH-4589, presumably because it was confusing there as well.2.) It's not recorded correctly on the backend (see GH-5554) and is not a high priority to fix in the near future.