Skip to content

Conversation

@ehfeng
Copy link
Contributor

@ehfeng ehfeng commented Sep 8, 2017

No description provided.

@ehfeng ehfeng requested a review from mattrobenolt September 8, 2017 18:35
@ehfeng ehfeng mentioned this pull request Sep 8, 2017
@ghost
Copy link

ghost commented Sep 8, 2017

1 Warning
⚠️ Changes require @getsentry/security sign-off

Security concerns found

  • src/sentry/receivers/email.py

Generated by 🚫 danger

@ehfeng ehfeng changed the title make delete_email receiver case-insensitive fix/Change delete_email Receiver to be Case-Insensitive Sep 8, 2017
@ehfeng ehfeng changed the title fix/Change delete_email Receiver to be Case-Insensitive fix/Change delete_email Receiver to be Case-Insensitive Sep 8, 2017
`UserEmail.email` is case sensitive but `Email.email` is case-insensitive.
We should only delete `Email` when there are no case-insensitive matching `UserEmail`
@ehfeng ehfeng merged commit c73670b into master Sep 8, 2017
@ehfeng ehfeng deleted the email-fix branch September 8, 2017 23:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants