Skip to content

Conversation

@ehfeng
Copy link
Contributor

@ehfeng ehfeng commented Sep 8, 2017

We need to backfill's Email with historical UserEmail.

Because the Email.email field is CIText, but UserEmail can easily have duplicates, not to mention case-insensitive duplicates, we wrap it in a try except.

@ehfeng ehfeng requested a review from dcramer September 8, 2017 20:16
@ghost
Copy link

ghost commented Sep 8, 2017

2 Warnings
⚠️ You should update CHANGES due to the size of this PR
⚠️ PR includes migrations

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

Because the `Email.email` field is CIText, we wrap it in a try except.
@ehfeng ehfeng changed the title Backfill the Email model from UserEmail backfill/Backfill Email Sep 8, 2017
@ehfeng ehfeng changed the title backfill/Backfill Email backfill/Backfill Email Sep 8, 2017
@ehfeng ehfeng changed the title backfill/Backfill Email backfill/Email model Sep 8, 2017
@ehfeng ehfeng merged commit 9454a03 into master Sep 8, 2017
@ehfeng ehfeng deleted the backfill-email branch September 8, 2017 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants