Skip to content

Conversation

@hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Feb 1, 2024

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 1, 2024
@hubertdeng123
Copy link
Member Author

Welp, still not failing when it should:
https://github.com/getsentry/sentry/actions/runs/7746390088/job/21124498064

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Feb 2, 2024

Ah, it's because getsentry and sentry have different filtering settings for FOSSA. Should that be the case though?

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Feb 2, 2024

Adding an unlicensed dependency in getsentry will fail the license compliance scanning job on a PR:
https://github.com/getsentry/getsentry/pull/12806.

@hubertdeng123 hubertdeng123 marked this pull request as ready for review February 2, 2024 04:28
@hubertdeng123 hubertdeng123 requested a review from a team as a code owner February 2, 2024 04:28
@hubertdeng123 hubertdeng123 requested a review from a team February 2, 2024 04:29
@hubertdeng123 hubertdeng123 merged commit 9785349 into master Feb 2, 2024
@hubertdeng123 hubertdeng123 deleted the fossa-fix branch February 2, 2024 23:26
cmanallen pushed a commit that referenced this pull request Feb 7, 2024
… jobs (#64399)

Picks up
getsentry/action-enforce-license-compliance#23

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants