fix(dynamic-sampling): add project-level permission check before adding custom rule #72153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72153 +/- ##
===========================================
+ Coverage 56.90% 77.96% +21.06%
===========================================
Files 6561 6570 +9
Lines 292460 292787 +327
Branches 50481 50539 +58
===========================================
+ Hits 166420 228283 +61863
+ Misses 121318 58258 -63060
- Partials 4722 6246 +1524
|
matejminar
approved these changes
Jun 6, 2024
Member
matejminar
left a comment
matejminar
left a comment
There was a problem hiding this comment.
Thank you for fixing this! 🙏
ArthurKnaus
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ng custom rule (#72153) If an organization user does not have project-level permission to a project (for example, with Open Membership disabled), they should not be allowed to create or view custom rules (aka _Get Samples_).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an organization user does not have project-level permission to a project (for example, with Open Membership disabled), they should not be allowed to create or view custom rules (aka Get Samples).