fix(dashboards): add project-level permission check for DiscoverSavedQueryDetailEndpoint #72159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Jun 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72159 +/- ##
==========================================
+ Coverage 76.93% 77.97% +1.03%
==========================================
Files 6570 6570
Lines 292774 292787 +13
Branches 50538 50542 +4
==========================================
+ Hits 225238 228292 +3054
+ Misses 61181 58252 -2929
+ Partials 6355 6243 -112
|
ArthurKnaus
pushed a commit
that referenced
this pull request
Jun 6, 2024
…QueryDetailEndpoint (#72159) If an organization user does not have project-level permission to a project (for example, with Open Membership disabled), they should not be allowed to do any actions with saved queries that are based on said project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an organization user does not have project-level permission to a project (for example, with Open Membership disabled), they should not be allowed to do any actions with saved queries that are based on said project.