Skip to content

Conversation

@ArthurKnaus
Copy link
Member

Move to components/metrics folder, as it is used in multiple places.

@ArthurKnaus ArthurKnaus requested a review from a team as a code owner June 6, 2024 06:13
@ArthurKnaus ArthurKnaus requested a review from a team June 6, 2024 06:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.97%. Comparing base (372ba1e) to head (9fdcc77).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72188      +/-   ##
==========================================
- Coverage   77.97%   77.97%   -0.01%     
==========================================
  Files        6577     6577              
  Lines      293015   293015              
  Branches    50574    50574              
==========================================
- Hits       228482   228481       -1     
+ Misses      58300    58238      -62     
- Partials     6233     6296      +63     
Files Coverage Δ
static/app/components/events/eventEntries.tsx 75.86% <ø> (ø)
...ts/interfaces/spans/newTraceDetailsSpanDetails.tsx 0.00% <ø> (ø)
.../components/events/interfaces/spans/spanDetail.tsx 56.29% <ø> (ø)
.../app/components/metrics/customMetricsEventData.tsx 77.35% <ø> (ø)
...newTraceDetails/traceDrawer/details/span/index.tsx 86.66% <ø> (ø)
...eDetails/traceDrawer/details/transaction/index.tsx 87.50% <ø> (ø)
.../performance/traceDetails/traceViewDetailPanel.tsx 0.00% <ø> (ø)

... and 108 files with indirect coverage changes

@ArthurKnaus ArthurKnaus merged commit e1d65ca into master Jun 6, 2024
@ArthurKnaus ArthurKnaus deleted the aknaus/ref/metrics/move-custom-metrics-event-data-to-components branch June 6, 2024 07:36
ArthurKnaus added a commit that referenced this pull request Jun 6, 2024
Move to `components/metrics` folder, as it is used in multiple places.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants