Skip to content

Conversation

@ArthurKnaus
Copy link
Member

Move QueryBuilder and related sub-components to components/metrics folder.

@ArthurKnaus ArthurKnaus requested review from a team as code owners June 6, 2024 06:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.97%. Comparing base (372ba1e) to head (71aba52).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72189      +/-   ##
==========================================
- Coverage   77.97%   77.97%   -0.01%     
==========================================
  Files        6577     6577              
  Lines      293015   293015              
  Branches    50574    50574              
==========================================
- Hits       228482   228481       -1     
+ Misses      58300    58238      -62     
- Partials     6233     6296      +63     
Files Coverage Δ
static/app/components/metrics/metricSearchBar.tsx 7.89% <ø> (ø)
static/app/components/metrics/mriSelect.tsx 30.43% <ø> (ø)
static/app/components/metrics/queryBuilder.tsx 0.00% <ø> (ø)
...ponents/modals/metricWidgetViewerModal/queries.tsx 0.00% <ø> (ø)
...p/views/alerts/rules/metric/ruleConditionsForm.tsx 71.32% <ø> (ø)
static/app/views/metrics/queries.tsx 0.00% <ø> (ø)

... and 108 files with indirect coverage changes

@ArthurKnaus ArthurKnaus merged commit 7ee0927 into master Jun 6, 2024
@ArthurKnaus ArthurKnaus deleted the aknaus/ref/metrics/move-query-builder-to-components branch June 6, 2024 07:37
ArthurKnaus added a commit that referenced this pull request Jun 6, 2024
Move `QueryBuilder` and related sub-components to `components/metrics`
folder.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants