ref(metrics): catch assertionerror and invalidparams in metrics api #72204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
obostjancic
approved these changes
Jun 6, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ).apply_transformer(MetricsAPIQueryResultsTransformer()) | ||
| except InvalidMetricsQueryError as e: | ||
| return Response(status=400, data={"detail": str(e)}) | ||
| except InvalidParams as e: |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72204 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 6576 6576
Lines 293026 293031 +5
Branches 50578 50580 +2
=======================================
+ Hits 228514 228521 +7
+ Misses 58274 58270 -4
- Partials 6238 6240 +2
|
shellmayr
deleted the
shellmayr/fix/return-400-instead-of-invalidparams-in-metrics-query-without-use-case
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.