feat(custom-views): Add styles to draggable tabs

.github/CODEOWNERS

@@ -85,23 +85,26 @@ Makefile                                                 @getsentry/owners-sentr
 /bin/react-to-product-owners-yml-changes.sh              @getsentry/open-source
 /static/app/components/sidebar/index.tsx                 @getsentry/open-source
 
+## Backup - getsentry/team-ospo#153
+/src/sentry/backup/                                      @getsentry/open-source
+/src/sentry/runner/commands/backup.py                    @getsentry/open-source
+/src/sentry/testutils/helpers/backups.py                 @getsentry/open-source
+/tests/sentry/backup/                                    @getsentry/open-source
+/tests/sentry/runner/commands/test_backup.py             @getsentry/open-source
+
 ## Relocation - getsentry/team-ospo#153
-/src/sentry/analytics/events/relocation_created.py       @getsentry/open-source
-/src/sentry/analytics/events/relocation_forked.py        @getsentry/open-source
-/src/sentry/analytics/events/relocation_organization_imported.py @getsentry/open-source
+/src/sentry/analytics/events/relocation_*.py             @getsentry/open-source
 /src/sentry/api/endpoints/organization_fork.py           @getsentry/open-source
 /src/sentry/api/endpoints/relocation/                    @getsentry/open-source
-/src/sentry/backup/                                      @getsentry/open-source
-/src/sentry/backup/services/import_export/               @getsentry/open-source
-/src/sentry/backup/services/relocation_export/           @getsentry/open-source
-/src/sentry/runner/commands/backup.py                    @getsentry/open-source
+/src/sentry/api/serialiers/models/relocation/            @getsentry/open-source
+/src/sentry/models/relocation/                           @getsentry/open-source
+/src/sentry/relocation/                                  @getsentry/open-source
 /src/sentry/tasks/relocation.py                          @getsentry/open-source
-/src/sentry/testutils/helpers/backups.py                 @getsentry/open-source
 /src/sentry/utils/relocation.py                          @getsentry/open-source
 /tests/sentry/api/endpoints/relocation                   @getsentry/open-source
-/tests/sentry/backup/                                    @getsentry/open-source
+/tests/sentry/api/endpoints/test_organization_fork.py    @getsentry/open-source
+/tests/sentry/api/serializer/test_relocation.py          @getsentry/open-source
 /tests/sentry/tasks/test_relocation.py                   @getsentry/open-source
-/tests/sentry/runner/commands/test_backup.py             @getsentry/open-source
 /tests/sentry/utils/test_relocation.py                   @getsentry/open-source
 
 ## Build & Releases

.github/workflows/backend.yml

@@ -307,7 +307,7 @@ jobs:
           python3 -m tools.fast_editable --path .
           sentry init
 
-      - run: mypy
+      - run: PYTHONWARNINGS=error::RuntimeWarning mypy
         id: run
 
       - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0

migrations_lockfile.txt

@@ -10,6 +10,6 @@ hybridcloud: 0016_add_control_cacheversion
 nodestore: 0002_nodestore_no_dictfield
 remote_subscriptions: 0003_drop_remote_subscription
 replays: 0004_index_together
-sentry: 0744_add_dataset_source_field_to_dashboards
+sentry: 0745_add_prevent_superuser_access_bitflag
 social_auth: 0002_default_auto_field
 uptime: 0006_projectuptimesubscription_name_owner

requirements-dev-frozen.txt

@@ -38,7 +38,7 @@ cssutils==2.9.0
 datadog==0.49.1
 distlib==0.3.8
 distro==1.8.0
-django==5.0.6
+django==5.0.7
 django-crispy-forms==1.14.0
 django-csp==3.8
 django-pg-zero-downtime-migrations==0.13
@@ -245,4 +245,4 @@ zstandard==0.18.0
 
 # The following packages are considered to be unsafe in a requirements file:
 pip==23.3.1
-setuptools==68.2.2
+setuptools==70.0.0

requirements-frozen.txt

@@ -32,7 +32,7 @@ cssselect==1.0.3
 cssutils==2.9.0
 datadog==0.49.1
 distro==1.8.0
-django==5.0.6
+django==5.0.7
 django-crispy-forms==1.14.0
 django-csp==3.8
 django-pg-zero-downtime-migrations==0.13
@@ -156,4 +156,4 @@ xmlsec==1.3.13
 zstandard==0.18.0
 
 # The following packages are considered to be unsafe in a requirements file:
-setuptools==68.2.2
+setuptools==70.0.0

src/sentry/api/base.py

@@ -221,8 +221,8 @@ class Endpoint(APIView):
 
     owner: ApiOwner = ApiOwner.UNOWNED
     publish_status: dict[HTTP_METHOD_NAME, ApiPublishStatus] = {}
-    rate_limits: RateLimitConfig | dict[
-        str, dict[RateLimitCategory, RateLimit]
+    rate_limits: RateLimitConfig | dict[str, dict[RateLimitCategory, RateLimit]] | Callable[
+        ..., RateLimitConfig | dict[str, dict[RateLimitCategory, RateLimit]]
     ] = DEFAULT_RATE_LIMIT_CONFIG
     enforce_rate_limit: bool = settings.SENTRY_RATELIMITER_ENABLED
     snuba_methods: list[HTTP_METHOD_NAME] = []

src/sentry/api/bases/organization_events.py

@@ -240,33 +240,39 @@ def handle_on_demand(self, request: Request) -> tuple[bool, MetricSpecType]:
 
         return use_on_demand_metrics, on_demand_metric_type
 
-    def get_split_decision(self, has_errors, has_transactions_data):
+    def save_split_decision(self, widget, has_errors, has_transactions_data, organization, user):
         """This can be removed once the discover dataset has been fully split"""
+        source = DashboardDatasetSourcesTypes.INFERRED.value
         if has_errors and not has_transactions_data:
             decision = DashboardWidgetTypes.ERROR_EVENTS
+            sentry_sdk.set_tag("discover.split_reason", "query_result")
         elif not has_errors and has_transactions_data:
             decision = DashboardWidgetTypes.TRANSACTION_LIKE
-        elif has_errors and has_transactions_data:
-            decision = DashboardWidgetTypes.DISCOVER
+            sentry_sdk.set_tag("discover.split_reason", "query_result")
         else:
-            # In the case that neither side has data, we do not need to split this yet and can make multiple queries to check each time.
-            # This will help newly created widgets or infrequent count widgets that shouldn't be prematurely assigned a side.
-            decision = None
-        sentry_sdk.set_tag("split_decision", decision)
-        return decision
+            if features.has(
+                "organizations:performance-discover-dataset-selector", organization, actor=user
+            ):
+                # In the case that neither side has data, or both sides have data, default to errors.
+                decision = DashboardWidgetTypes.ERROR_EVENTS
+                source = DashboardDatasetSourcesTypes.FORCED.value
+                sentry_sdk.set_tag("discover.split_reason", "default")
+            else:
+                # This branch can be deleted once the feature flag for the discover split is removed
+                if has_errors and has_transactions_data:
+                    decision = DashboardWidgetTypes.DISCOVER
+                else:
+                    # In the case that neither side has data, we do not need to split this yet and can make multiple queries to check each time.
+                    # This will help newly created widgets or infrequent count widgets that shouldn't be prematurely assigned a side.
+                    decision = None
 
-    def save_split_decision(self, widget, has_errors, has_transactions_data):
-        """This can be removed once the discover dataset has been fully split"""
-        new_discover_widget_split = self.get_split_decision(has_errors, has_transactions_data)
-        if (
-            new_discover_widget_split is not None
-            and widget.discover_widget_split != new_discover_widget_split
-        ):
-            widget.discover_widget_split = new_discover_widget_split
-            widget.dataset_source = DashboardDatasetSourcesTypes.INFERRED.value
+        sentry_sdk.set_tag("discover.split_decision", decision)
+        if decision is not None and widget.discover_widget_split != decision:
+            widget.discover_widget_split = decision
+            widget.dataset_source = source
             widget.save()
 
-        return new_discover_widget_split
+        return decision
 
     def save_discover_saved_query_split_decision(
         self, query, dataset_inferred_from_query, has_errors, has_transactions_data

src/sentry/api/endpoints/auth_index.py

@@ -18,6 +18,7 @@
 from sentry.api.validators import AuthVerifyValidator
 from sentry.api.validators.auth import MISSING_PASSWORD_OR_U2F_CODE
 from sentry.auth.authenticators.u2f import U2fInterface
+from sentry.auth.providers.saml2.provider import handle_saml_single_logout
 from sentry.auth.services.auth.impl import promote_request_rpc_user
 from sentry.auth.superuser import SUPERUSER_ORG_ID
 from sentry.models.authenticator import Authenticator
@@ -293,6 +294,8 @@ def delete(self, request: Request, *args, **kwargs) -> Response:
 
         Deauthenticate all active sessions for this user.
         """
+        handle_saml_single_logout(request)
+
         # For signals to work here, we must promote the request.user to a full user object
         logout(request._request)
         request.user = AnonymousUser()

src/sentry/api/endpoints/group_ai_autofix.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import logging
-from datetime import datetime
+from datetime import datetime, timedelta
 from typing import Any
 
 import orjson
@@ -16,10 +16,11 @@
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases.group import GroupEndpoint
 from sentry.api.serializers import EventSerializer, serialize
-from sentry.autofix.utils import get_autofix_repos_from_project_code_mappings
+from sentry.autofix.utils import get_autofix_repos_from_project_code_mappings, get_autofix_state
 from sentry.models.group import Group
 from sentry.models.user import User
 from sentry.seer.signed_seer_api import sign_with_seer_secret
+from sentry.tasks.autofix import check_autofix_status
 from sentry.types.ratelimit import RateLimit, RateLimitCategory
 from sentry.users.services.user.service import user_service
 
@@ -133,33 +134,7 @@ def _call_autofix(
 
         response.raise_for_status()
 
-    def _call_get_autofix_state(self, group_id: int) -> dict[str, Any] | None:
-        path = "/v1/automation/autofix/state"
-        body = orjson.dumps(
-            {
-                "group_id": group_id,
-            }
-        )
-        response = requests.post(
-            f"{settings.SEER_AUTOFIX_URL}{path}",
-            data=body,
-            headers={
-                "content-type": "application/json;charset=utf-8",
-                **sign_with_seer_secret(
-                    url=f"{settings.SEER_AUTOFIX_URL}{path}",
-                    body=body,
-                ),
-            },
-        )
-
-        response.raise_for_status()
-
-        result = response.json()
-
-        if result and result["group_id"] == group_id:
-            return result["state"]
-
-        return None
+        return response.json().get("run_id")
 
     def post(self, request: Request, group: Group) -> Response:
         data = orjson.loads(request.body)
@@ -203,7 +178,7 @@ def post(self, request: Request, group: Group) -> Response:
             )
 
         try:
-            self._call_autofix(
+            run_id = self._call_autofix(
                 request.user,
                 group,
                 repos,
@@ -226,15 +201,20 @@ def post(self, request: Request, group: Group) -> Response:
                 500,
             )
 
+        check_autofix_status.apply_async(args=[run_id], countdown=timedelta(minutes=15).seconds)
+
         return Response(
             status=202,
         )
 
     def get(self, request: Request, group: Group) -> Response:
-        autofix_state = self._call_get_autofix_state(group.id)
+        autofix_state = get_autofix_state(group_id=group.id)
+
+        response_state: dict[str, Any] | None = None
 
         if autofix_state:
-            user_ids = autofix_state.get("actor_ids", [])
+            response_state = autofix_state.dict()
+            user_ids = autofix_state.actor_ids
             if user_ids:
                 users = user_service.serialize_many(
                     filter={"user_ids": user_ids, "organization_id": request.organization.id},
@@ -243,6 +223,6 @@ def get(self, request: Request, group: Group) -> Response:
 
                 users_map = {user["id"]: user for user in users}
 
-                autofix_state["users"] = users_map
+                response_state["users"] = users_map
 
-        return Response({"autofix": autofix_state})
+        return Response({"autofix": response_state})

src/sentry/api/endpoints/organization_dashboard_details.py

@@ -2,6 +2,7 @@
 from django.db import IntegrityError, router, transaction
 from django.db.models import F
 from django.utils import timezone
+from drf_spectacular.utils import extend_schema
 from rest_framework.request import Request
 from rest_framework.response import Response
 
@@ -13,7 +14,16 @@
 from sentry.api.endpoints.organization_dashboards import OrganizationDashboardsPermission
 from sentry.api.exceptions import ResourceDoesNotExist
 from sentry.api.serializers import serialize
+from sentry.api.serializers.models.dashboard import DashboardDetailsModelSerializer
 from sentry.api.serializers.rest_framework import DashboardDetailsSerializer
+from sentry.apidocs.constants import (
+    RESPONSE_BAD_REQUEST,
+    RESPONSE_FORBIDDEN,
+    RESPONSE_NO_CONTENT,
+    RESPONSE_NOT_FOUND,
+)
+from sentry.apidocs.examples.dashboard_examples import DashboardExamples
+from sentry.apidocs.parameters import DashboardParams, GlobalParams
 from sentry.models.dashboard import Dashboard, DashboardTombstone
 
 EDIT_FEATURE = "organizations:dashboards-edit"
@@ -44,24 +54,28 @@ def _get_dashboard(self, request: Request, organization, dashboard_id):
         return Dashboard.objects.get(id=dashboard_id, organization_id=organization.id)
 
 
+@extend_schema(tags=["Dashboards"])
 @region_silo_endpoint
 class OrganizationDashboardDetailsEndpoint(OrganizationDashboardBase):
     publish_status = {
-        "DELETE": ApiPublishStatus.UNKNOWN,
-        "GET": ApiPublishStatus.UNKNOWN,
-        "PUT": ApiPublishStatus.UNKNOWN,
+        "DELETE": ApiPublishStatus.PUBLIC,
+        "GET": ApiPublishStatus.PUBLIC,
+        "PUT": ApiPublishStatus.PUBLIC,
     }
 
+    @extend_schema(
+        operation_id="Retrieve an Organization's Custom Dashboard",
+        parameters=[GlobalParams.ORG_ID_OR_SLUG, DashboardParams.DASHBOARD_ID],
+        responses={
+            200: DashboardDetailsModelSerializer,
+            403: RESPONSE_FORBIDDEN,
+            404: RESPONSE_NOT_FOUND,
+        },
+        examples=DashboardExamples.DASHBOARD_GET_RESPONSE,
+    )
     def get(self, request: Request, organization, dashboard) -> Response:
         """
-        Retrieve an Organization's Dashboard
-        ````````````````````````````````````
-
-        Return details on an individual organization's dashboard.
-
-        :pparam Organization organization: the organization the dashboard belongs to.
-        :pparam Dashboard dashboard: the dashboard object
-        :auth: required
+        Return details about an organization's custom dashboard.
         """
         if not features.has(READ_FEATURE, organization, actor=request.user):
             return Response(status=404)
@@ -71,17 +85,19 @@ def get(self, request: Request, organization, dashboard) -> Response:
 
         return self.respond(serialize(dashboard, request.user))
 
+    @extend_schema(
+        operation_id="Delete an Organization's Custom Dashboard",
+        parameters=[GlobalParams.ORG_ID_OR_SLUG, DashboardParams.DASHBOARD_ID],
+        responses={
+            204: RESPONSE_NO_CONTENT,
+            403: RESPONSE_FORBIDDEN,
+            404: RESPONSE_NOT_FOUND,
+        },
+    )
     def delete(self, request: Request, organization, dashboard) -> Response:
         """
-        Delete an Organization's Dashboard
-        ```````````````````````````````````
-
-        Delete an individual organization's dashboard, or tombstone
+        Delete an organization's custom dashboard, or tombstone
         a pre-built dashboard which effectively deletes it.
-
-        :pparam Organization organization: the organization the dashboard belongs to.
-        :pparam Dashboard dashboard: the dashboard object
-        :auth: required
         """
         if not features.has(EDIT_FEATURE, organization, actor=request.user):
             return Response(status=404)
@@ -105,17 +121,24 @@ def delete(self, request: Request, organization, dashboard) -> Response:
 
         return self.respond(status=204)
 
+    @extend_schema(
+        operation_id="Edit an Organization's Custom Dashboard",
+        parameters=[GlobalParams.ORG_ID_OR_SLUG, DashboardParams.DASHBOARD_ID],
+        request=DashboardDetailsSerializer,
+        responses={
+            200: DashboardDetailsModelSerializer,
+            400: RESPONSE_BAD_REQUEST,
+            403: RESPONSE_FORBIDDEN,
+            404: RESPONSE_NOT_FOUND,
+        },
+        examples=DashboardExamples.DASHBOARD_PUT_RESPONSE,
+    )
     def put(self, request: Request, organization, dashboard) -> Response:
         """
-        Edit an Organization's Dashboard
-        ```````````````````````````````````
-
-        Edit an individual organization's dashboard as well as
-        bulk edits on widgets (i.e. rearranging widget order).
-
-        :pparam Organization organization: the organization the dashboard belongs to.
-        :pparam Dashboard dashboard: the old dashboard object
-        :auth: required
+        Edit an organization's custom dashboard as well as any bulk
+        edits on widgets that may have been made. (For example, widgets
+        that have been rearranged, updated queries and fields, specific
+        display types, and so on.)
         """
         if not features.has(EDIT_FEATURE, organization, actor=request.user):
             return Response(status=404)