Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

Removes unneeded feature check due to GA

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 18, 2024
@codecov
Copy link

codecov bot commented Jul 18, 2024

Bundle Report

Changes will decrease total bundle size by 8.65kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 28.05MB 8.65kB ⬇️

@codecov
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (dd7061a) to head (9b55067).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74500      +/-   ##
==========================================
- Coverage   78.13%   78.13%   -0.01%     
==========================================
  Files        6687     6686       -1     
  Lines      299151   299137      -14     
  Branches    51516    51511       -5     
==========================================
- Hits       233742   233728      -14     
+ Misses      59090    59087       -3     
- Partials     6319     6322       +3     
Files Coverage Δ
...ls/components/performanceScoreRingWithTooltips.tsx 60.24% <100.00%> (-0.94%) ⬇️
...bVitals/components/tables/pagePerformanceTable.tsx 56.09% <ø> (-5.08%) ⬇️
...redScoreQueries/useProjectWebVitalsScoresQuery.tsx 68.75% <ø> (-7.73%) ⬇️
...ing/widgets/widgets/performanceScoreListWidget.tsx 71.42% <100.00%> (+1.66%) ⬆️
...mponents/charts/performanceScoreBreakdownChart.tsx 65.11% <50.00%> (-0.11%) ⬇️
...coreQueries/useTransactionWebVitalsScoresQuery.tsx 60.00% <0.00%> (+6.15%) ⬆️

... and 1 file with indirect coverage changes

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review July 18, 2024 18:45
@edwardgou-sentry edwardgou-sentry requested a review from a team July 18, 2024 18:45
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@edwardgou-sentry edwardgou-sentry merged commit 0ee08a0 into master Jul 29, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/chore/remove-static-weight-scoring-feature-check branch July 29, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants