chore(insights): removes unused performance score flag checks #74504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74504 +/- ##
=======================================
Coverage 78.13% 78.13%
=======================================
Files 6687 6687
Lines 299151 299144 -7
Branches 51516 51514 -2
=======================================
+ Hits 233742 233745 +3
+ Misses 59090 59082 -8
+ Partials 6319 6317 -2
|
Dav1dde
approved these changes
Jul 18, 2024
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
You didn't delete the options, but I assume that was intentional?
Contributor
Author
Yeah I have a separate pr to delete the options here plus an extra one |
edwardgou-sentry
deleted the
egou/chore/remove-flag-checks-for-performance-score
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
organizations:insights-browser-webvitals-optional-componentsandorganizations:insights-default-performance-score-profilessince these flags have been GA'd and no longer needed.