-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(replay): refactor replayerStepper calls to be memoized #74606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7782d24
ref(replay): refactor replayerStepper to be called once
michellewzhang e31f109
:recycle: ref
michellewzhang ec15b19
:recycle: consolidate & standardize hooks
michellewzhang f3154c6
:truck: rename files
michellewzhang af73b5a
:recycle: some types
michellewzhang 873e5c9
:label: types
michellewzhang 38867b2
:recycle: ref so it works
michellewzhang 70c9054
:recycle: clean up
michellewzhang d4190ce
ref(replay): refactor replayerStepper calls to be memoized
michellewzhang c0f6811
:recycle: types
michellewzhang 8f160ef
:label: TYPO
michellewzhang fb68487
:recycle: new isLoading
michellewzhang e27a72d
:recycle: use RAF
michellewzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
52 changes: 2 additions & 50 deletions
52
static/app/utils/replays/extractDomNodes.tsx → static/app/utils/replays/extractHtml.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import {useQuery, type UseQueryResult} from 'sentry/utils/queryClient'; | ||
| import type ReplayReader from 'sentry/utils/replays/replayReader'; | ||
| import type {RecordingFrame} from 'sentry/utils/replays/types'; | ||
|
|
||
| export type DomNodeChartDatapoint = { | ||
| added: number; | ||
| count: number; | ||
| endTimestampMs: number; | ||
| removed: number; | ||
| startTimestampMs: number; | ||
| timestampMs: number; | ||
| }; | ||
|
|
||
| export default function useCountDomNodes({ | ||
| replay, | ||
| }: { | ||
| replay: null | ReplayReader; | ||
| }): UseQueryResult<Map<RecordingFrame, DomNodeChartDatapoint>> { | ||
| return useQuery( | ||
| ['countDomNodes', replay], | ||
| () => { | ||
| return replay?.getCountDomNodes(); | ||
| }, | ||
| {enabled: Boolean(replay), cacheTime: Infinity} | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import {useQuery, type UseQueryResult} from 'sentry/utils/queryClient'; | ||
| import type {Extraction} from 'sentry/utils/replays/extractHtml'; | ||
| import type ReplayReader from 'sentry/utils/replays/replayReader'; | ||
| import type {ReplayFrame} from 'sentry/utils/replays/types'; | ||
|
|
||
| export default function useExtractDomNodes({ | ||
| replay, | ||
| }: { | ||
| replay: null | ReplayReader; | ||
| }): UseQueryResult<Map<ReplayFrame, Extraction>> { | ||
| return useQuery( | ||
| ['getDomNodes', replay], | ||
| () => { | ||
| return replay?.getExtractDomNodes(); | ||
| }, | ||
| {enabled: Boolean(replay), cacheTime: Infinity} | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to
replayReader.tsx, so i renamed this file