Skip to content

Conversation

@leedongwei
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 23, 2024
@codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (0d530a6) to head (97ddc73).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74711      +/-   ##
==========================================
- Coverage   78.14%   78.14%   -0.01%     
==========================================
  Files        6731     6731              
  Lines      300214   300233      +19     
  Branches    51642    51645       +3     
==========================================
- Hits       234608   234603       -5     
- Misses      59285    59305      +20     
- Partials     6321     6325       +4     
Files Coverage Δ
src/sentry/api/endpoints/auth_index.py 78.35% <100.00%> (-1.95%) ⬇️
src/sentry/auth/providers/saml2/provider.py 77.41% <26.31%> (-6.02%) ⬇️

... and 8 files with indirect coverage changes

@leedongwei leedongwei force-pushed the dlee/implement-sls branch from 9af15ea to 3cabdd0 Compare July 23, 2024 16:55
@leedongwei leedongwei requested a review from a team July 23, 2024 16:57
@leedongwei leedongwei marked this pull request as ready for review July 23, 2024 16:57
@leedongwei leedongwei requested review from a team as code owners July 23, 2024 16:57
@leedongwei leedongwei enabled auto-merge (squash) July 23, 2024 17:22
mdtro
mdtro previously requested changes Jul 23, 2024
Copy link
Contributor

@mdtro mdtro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this functionality?

@leedongwei leedongwei force-pushed the dlee/implement-sls branch from 97ddc73 to 90b3c3c Compare July 23, 2024 19:52
@leedongwei leedongwei merged commit 1c3a348 into master Jul 23, 2024
@leedongwei leedongwei deleted the dlee/implement-sls branch July 23, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants