Still display tokens used if no token cost metric has been sent #74742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
reviewed
Jul 23, 2024
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Up to you if you want to make it nullable, or add explicit handling here! Error checking is a good idea though
static/app/views/insights/llmMonitoring/components/tables/pipelinesTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/insights/llmMonitoring/components/tables/pipelinesTable.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
gggritso
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have never sent a span with ai.model_id, the span metric ai.total_cost will never be extracted, and then the indexer will throw an error if you try to look for it.
This separates the "ai.total_cost" and "ai.total_tokens.used" table entries