chore(features) Expand documentation for sentry.features #74943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the documentation for features.handler and features.manager.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74943 +/- ##
==========================================
+ Coverage 70.65% 78.14% +7.48%
==========================================
Files 6742 6752 +10
Lines 300897 301371 +474
Branches 51757 51843 +86
==========================================
+ Hits 212609 235495 +22886
+ Misses 81442 59536 -21906
+ Partials 6846 6340 -506
|
cmanallen
approved these changes
Jul 29, 2024
Comment on lines
20
to
26
| """ | ||
| Base class for defining custom logic for feature decisions. | ||
| Subclasses should implement `has` and contain the logic | ||
| necessary for the feature check. | ||
| """ | ||
|
|
Member
There was a problem hiding this comment.
Since this is the root it may be helpful to enumerate common use-cases, any recommended do's and don'ts, file locations to place flags, instructions for (or links to instructions for) enabling flags in relay and other services, etc.
Member
Author
There was a problem hiding this comment.
I've added a bit more context, and can go through the getsentry code and expand documentation there as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the documentation for features.handler and features.manager.