Skip to content

Conversation

@Zylphrex
Copy link
Member

…overview

Without changing the end user experience, we're changing the profile column to render an profile button that links to the underlying profile regardless of if it's a transaction profile or a continuous profile.

…overview

Without changing the end user experience, we're changing the profile column to
render an profile button that links to the underlying profile regardless of
if it's a transaction profile or a continuous profile.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 26, 2024
@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (6fb96c4) to head (51d1315).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75099      +/-   ##
==========================================
- Coverage   78.12%   78.12%   -0.01%     
==========================================
  Files        6748     6749       +1     
  Lines      301237   301281      +44     
  Branches    51841    51849       +8     
==========================================
+ Hits       235351   235371      +20     
- Misses      59556    59584      +28     
+ Partials     6330     6326       -4     
Files Coverage Δ
.../newTraceDetails/traceDrawer/traceProfilingLink.ts 59.45% <100.00%> (+2.64%) ⬆️
...atic/app/components/discover/transactionsTable.tsx 77.61% <33.33%> (ø)
static/app/utils/dates.tsx 89.74% <42.85%> (-4.63%) ⬇️
...transactionSummary/transactionOverview/content.tsx 68.93% <0.00%> (-4.27%) ⬇️
...app/views/performance/transactionSummary/utils.tsx 66.66% <28.57%> (-10.08%) ⬇️

... and 23 files with indirect coverage changes

@Zylphrex Zylphrex marked this pull request as ready for review July 29, 2024 14:32
@Zylphrex Zylphrex requested a review from a team July 29, 2024 14:32
@Zylphrex Zylphrex merged commit 7f458d2 into master Jul 29, 2024
@Zylphrex Zylphrex deleted the txiao/feat/support-both-transaction-and-continuous-profiles-in-transaction-summary-overview branch July 29, 2024 16:17
Zylphrex added a commit that referenced this pull request Jul 29, 2024
Similar to #75099. This will render a profiling icon to link to the
transaction/continuous profile automatically based on the data ingested.
Zylphrex added a commit that referenced this pull request Jul 29, 2024
Similar to #75099. This will render a profiling icon to link to the
transaction/continuous profile automatically based on the data ingested.
Zylphrex added a commit that referenced this pull request Jul 29, 2024
…tab (#75165)

Similar to #75099. This will render a profiling icon to link to the
transaction/continuous profile automatically based on the data ingested.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants