-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(issue-details): Move Issues tabs to data sections #77340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #77340 +/- ##
========================================
Coverage 78.08% 78.08%
========================================
Files 6975 6986 +11
Lines 309541 309723 +182
Branches 50673 50697 +24
========================================
+ Hits 241693 241862 +169
+ Misses 61419 61392 -27
- Partials 6429 6469 +40 |
Bundle ReportChanges will decrease total bundle size by 100.58kB (-0.34%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
5725be1
to
cb5e3a6
Compare
cb5e3a6
to
4a0fceb
Compare
scttcper
reviewed
Sep 18, 2024
static/app/views/issueDetails/groupSimilarIssues/similarIssuesDataSection.tsx
Outdated
Show resolved
Hide resolved
scttcper
reviewed
Sep 18, 2024
scttcper
approved these changes
Sep 18, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
Converts the tabs to folding data sections. They are rendered as is, and we can introduce new designs if we have more time later on, but for now, styling and text sizes are the same.    **todo** - [x] Add tests for their new location - [ ] Figure out subrouting so directly linking to `/merged` and `/similar` does something expected --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
roaga
pushed a commit
that referenced
this pull request
Sep 20, 2024
Converts the tabs to folding data sections. They are rendered as is, and we can introduce new designs if we have more time later on, but for now, styling and text sizes are the same.    **todo** - [x] Add tests for their new location - [ ] Figure out subrouting so directly linking to `/merged` and `/similar` does something expected --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the tabs to folding data sections. They are rendered as is, and we can introduce new designs if we have more time later on, but for now, styling and text sizes are the same.
todo
/merged
and/similar
does something expected