Skip to content

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Sep 11, 2024

Converts the tabs to folding data sections. They are rendered as is, and we can introduce new designs if we have more time later on, but for now, styling and text sizes are the same.

image

image

image

todo

  • Add tests for their new location
  • Figure out subrouting so directly linking to /merged and /similar does something expected

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #77340    +/-   ##
========================================
  Coverage   78.08%   78.08%            
========================================
  Files        6975     6986    +11     
  Lines      309541   309723   +182     
  Branches    50673    50697    +24     
========================================
+ Hits       241693   241862   +169     
+ Misses      61419    61392    -27     
- Partials     6429     6469    +40     

Copy link

codecov bot commented Sep 12, 2024

Bundle Report

Changes will decrease total bundle size by 100.58kB (-0.34%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 29.24MB 100.58kB (-0.34%) ⬇️

@leeandher leeandher marked this pull request as ready for review September 12, 2024 20:37
@leeandher leeandher requested a review from a team as a code owner September 12, 2024 20:37
@leeandher leeandher force-pushed the leander/rm-similar-merged-issues branch from 5725be1 to cb5e3a6 Compare September 17, 2024 20:26
@leeandher leeandher force-pushed the leander/rm-similar-merged-issues branch from cb5e3a6 to 4a0fceb Compare September 18, 2024 15:47
@leeandher leeandher merged commit cb1afc4 into master Sep 19, 2024
44 checks passed
@leeandher leeandher deleted the leander/rm-similar-merged-issues branch September 19, 2024 18:26
harshithadurai pushed a commit that referenced this pull request Sep 19, 2024
Converts the tabs to folding data sections. They are rendered as is, and
we can introduce new designs if we have more time later on, but for now,
styling and text sizes are the same.



![image](https://github.com/user-attachments/assets/2581519f-214d-4b30-bf07-9d1cbe2412da)


![image](https://github.com/user-attachments/assets/8e5f68ae-21b4-4641-ac15-eab026b310c7)


![image](https://github.com/user-attachments/assets/195e1241-67e2-4432-a456-a653901c6c86)

**todo**
- [x] Add tests for their new location
- [ ] Figure out subrouting so directly linking to `/merged` and
`/similar` does something expected

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
roaga pushed a commit that referenced this pull request Sep 20, 2024
Converts the tabs to folding data sections. They are rendered as is, and
we can introduce new designs if we have more time later on, but for now,
styling and text sizes are the same.



![image](https://github.com/user-attachments/assets/2581519f-214d-4b30-bf07-9d1cbe2412da)


![image](https://github.com/user-attachments/assets/8e5f68ae-21b4-4641-ac15-eab026b310c7)


![image](https://github.com/user-attachments/assets/195e1241-67e2-4432-a456-a653901c6c86)

**todo**
- [x] Add tests for their new location
- [ ] Figure out subrouting so directly linking to `/merged` and
`/similar` does something expected

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants