Skip to content

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 18, 2024

  • Need to look into why, but looks like the default tags list is
    different in EAP?

- Hmm can't repro this, and we are hitting the drop endpoint for the
  spans db
- Need to look into why, but looks like the default tags list is
  different in EAP?
@wmak wmak marked this pull request as ready for review September 19, 2024 15:25
@wmak wmak requested a review from a team as a code owner September 19, 2024 15:25
**kwargs,
)

def test_tags_list(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there two test_tags_list ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah one is inheriting from OrganizationSpansTagsEndpointTest while the other is that class

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 19, 2024
@wmak wmak requested a review from colin-sentry September 19, 2024 18:56
@wmak wmak merged commit 61a2837 into master Sep 19, 2024
50 checks passed
@wmak wmak deleted the wmak/fix/span-field-test branch September 19, 2024 19:44
roaga pushed a commit that referenced this pull request Sep 20, 2024
- Need to look into why, but looks like the default tags list is
  different in EAP?
Copy link

sentry-io bot commented Sep 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: {'detail': 'Internal Error', 'errorId': None} pytest.runtest.protocol tests/sentry/api/endpoi... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants