feat(onboarding): Replace wizard url flag with saas flag #78248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obostjancic
approved these changes
Sep 27, 2024
github-actions
bot
added
the
Scope: Frontend
vgrozdanic
approved these changes
Sep 27, 2024
Lms24
approved these changes
Sep 27, 2024
| }: Params) => { | ||
| const urlParam = !isSelfHosted && urlPrefix ? `--url ${urlPrefix}` : ''; | ||
| const getInstallConfig = ({isSelfHosted, organization, projectSlug}: Params) => { | ||
| const urlParam = isSelfHosted ? '' : '--saas'; |
There was a problem hiding this comment.
l/to follow up on: Should we think about displaying --url <selfHostedUrl> for self-hosted users? Probably not the end of the world if they are confronted with the "are you using saas/selfhosted" question in the wizard but might be nice.
There was a problem hiding this comment.
Yeah, we thought about it, but there were some challenges with figuring out the right urlPrefix.
This will act as a progressive enhancement for saas. Self-hosted will still work, but they will have to answer this question in the wizard.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to getsentry/sentry-wizard#678