Add */up to HEALTH_CHECK_GLOBS
#78751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78751 +/- ##
===========================================
+ Coverage 62.76% 78.24% +15.47%
===========================================
Files 4070 7105 +3035
Lines 124873 313066 +188193
Branches 20206 51121 +30915
===========================================
+ Hits 78381 244950 +166569
- Misses 46193 61754 +15561
- Partials 299 6362 +6063 |
Dav1dde
approved these changes
Oct 8, 2024
Dav1dde
pushed a commit
to getsentry/relay
that referenced
this pull request
Oct 8, 2024
Rails 7 uses `/up` as a default health check endpoint, this only adds the tests for it, change is necessary in Sentry to actually filter. getsentry/sentry-docs#11505 getsentry/sentry#78751
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Rails 7 and Laravel 11 expose an
/uphealth-check endpoint which we should ignore.Refs getsentry/relay#4117