Skip to content

fix(dashboards): Fix re-use of widget data in Widget Viewer modal #80861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(dashboards): Fix re-use of widget data in Widget Viewer modal #80861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion static/app/views/dashboards/widgetCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useState} from 'react';
import {useContext, useState} from 'react';
import styled from '@emotion/styled';
import type {LegendComponentOption} from 'echarts';
import type {Location} from 'history';
Expand Down Expand Up @@ -40,6 +40,7 @@ import type WidgetLegendSelectionState from '../widgetLegendSelectionState';
import {BigNumberWidget} from '../widgets/bigNumberWidget/bigNumberWidget';
import type {Meta} from '../widgets/common/types';
import {WidgetFrame} from '../widgets/common/widgetFrame';
import {WidgetViewerContext} from '../widgetViewer/widgetViewerContext';

import {useDashboardsMEPContext} from './dashboardsMEPContext';
import WidgetCardChartContainer from './widgetCardChartContainer';
Expand Down Expand Up @@ -100,6 +101,7 @@ type Data = {

function WidgetCard(props: Props) {
const [data, setData] = useState<Data>();
const {setData: setWidgetViewerData} = useContext(WidgetViewerContext);

const onDataFetched = (newData: Data) => {
if (props.onDataFetched && newData.tableResults) {
Expand Down Expand Up @@ -174,6 +176,14 @@ function WidgetCard(props: Props) {

const onFullScreenViewClick = () => {
if (!isWidgetViewerPath(location.pathname)) {
setWidgetViewerData({
pageLinks: data?.pageLinks,
seriesData: data?.timeseriesResults,
tableData: data?.tableResults,
seriesResultsType: data?.timeseriesResultsTypes,
totalIssuesCount: data?.totalIssuesCount,
});

props.router.push({
pathname: `${location.pathname}${
location.pathname.endsWith('/') ? '' : '/'
Expand Down
Loading